Adding multipart/mixed as an html content type.#35
Open
jxmallett wants to merge 1 commit intoOpenBuildings:masterfrom
jxmallett:ct-fix
Open
Adding multipart/mixed as an html content type.#35jxmallett wants to merge 1 commit intoOpenBuildings:masterfrom jxmallett:ct-fix
jxmallett wants to merge 1 commit intoOpenBuildings:masterfrom
jxmallett:ct-fix
Conversation
christheyounger
approved these changes
May 25, 2017
Contributor
christheyounger
left a comment
christheyounger
left a comment
There was a problem hiding this comment.
Works for me and allows sending HTML messages with attachments, which otherwise get the HTML put in the plain text part.
Contributor
|
@jxmallett Could you please look into the failing tests? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the Swift content type changes to
multipart/mixed. I believe the message should be treated ashtmlrather thantext.Unfortunately I can't find any clear documentation on exactly when the content type changes. In my case I noticed it when creating an html email which includes inline images and/or document attachments.